Skip to content

test(NODE-6834): fix flaky x509 test #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

test(NODE-6834): fix flaky x509 test #4498

merged 1 commit into from
Apr 4, 2025

Conversation

durran
Copy link
Member

@durran durran commented Apr 4, 2025 •
edited
Loading

Description

Fixes the flaky x509 test.

What is changing?

Change tests to run against a standalone instead of sharded cluster.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6834

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran changed the title fix: flaky x509 test test: fix flaky x509 test Apr 4, 2025
durran
durran commented Apr 4, 2025
View reviewed changes
@durran durran changed the title test: fix flaky x509 test test(NODE-6834): fix flaky x509 test Apr 4, 2025
@durran durran marked this pull request as ready for review April 4, 2025 12:48
@durran durran requested a review from a team as a code owner April 4, 2025 12:48
@baileympearson baileympearson self-assigned this Apr 4, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 4, 2025
baileympearson
baileympearson approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot reproduce with 1000 iterations locally. Testing with a sharded cluster locally reproduces in <10 iterations.

@baileympearson baileympearson merged commit cb88b05 into main Apr 4, 2025
27 of 28 checks passed
@baileympearson baileympearson deleted the NODE-6834 branch April 4, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@durran @baileympearson