Skip to content

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Apr 18, 2025

Description

What is changing?

  • quick search and replace fix for return -> return await
  • Add names to our operation functions
Is there new documentation needed for these changes?

What is the motivation for this change?

BEFORE:

      at async executeOperation (src/operations/execute_operation.ts:115:12)
      at async Collection.insertMany (src/collection.ts:307:12)
      at async executeOperationAndCheck (test/tools/unified-spec-runner/operations.ts:1030:14)

AFTER:

      at async executeOperation (src/operations/execute_operation.ts:115:12)
      at async Collection.insertMany (src/collection.ts:307:12)
      at async insertMany (test/tools/unified-spec-runner/operations.ts:411:10)
      at async executeOperationAndCheck (test/tools/unified-spec-runner/operations.ts:1039:14)

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from a team as a code owner April 18, 2025 18:27
@baileympearson baileympearson self-assigned this Apr 18, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 18, 2025
@baileympearson baileympearson merged commit efffb50 into main Apr 18, 2025
27 of 28 checks passed
@baileympearson baileympearson deleted the chore-return-await-utr branch April 18, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants