Skip to content

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jun 27, 2025

Description

What is changing?

With this change, we now always enable compression in CI when COMPRESSOR is set in the environment.

Some tests did fail with this change. Most were tests that manipulate OP_MSG directly failed because we use OP_COMPRESSED when compression is enabled. Some other issues:

  • compression makes logging events longer, which can exceed the max document length limit in logging tests
  • compression makes socket write asynchronous, which I believe was causing timing issues (resulting in the leak checker reporting that the a session was leaked) in one place we forgot to await a client.close()
Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review June 27, 2025 17:55
@baileympearson baileympearson requested a review from a team as a code owner June 27, 2025 17:55
@durran durran self-assigned this Jun 30, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 30, 2025
durran
durran previously approved these changes Jun 30, 2025
@dariakp dariakp merged commit 54c5740 into mongodb:main Jul 1, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants