Skip to content

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jul 22, 2025

Description

What is changing?

https://jira.mongodb.org/browse/NODE-4884 was closed in favor of https://jira.mongodb.org/browse/NODE-5754, and as such the TODOs were missed in our test suite. This PR removes the TODOs and unnecessary specification of family: 4.

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title remove unnecessary family specification chore(NODE-4884): remove unnecessary ip address family specification in tests Jul 22, 2025
@baileympearson baileympearson marked this pull request as ready for review July 22, 2025 21:09
@baileympearson baileympearson requested a review from a team as a code owner July 22, 2025 21:09
@durran durran self-assigned this Jul 22, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 22, 2025
@durran durran merged commit d92acfc into mongodb:main Jul 22, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants