Skip to content

test(NODE-6944): unskip ldap and kerberos tests #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2025
Merged

test(NODE-6944): unskip ldap and kerberos tests #4591

merged 3 commits into from
Jul 22, 2025

Conversation

durran
Copy link
Member

@durran durran commented Jul 22, 2025 •
edited
Loading

Description

Unskips the LDAP and Kerberos tests.

What is changing?

  • Unskips the tests
  • Adds assume secret manager role to the runs.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6944

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review July 22, 2025 20:30
@durran durran requested a review from a team as a code owner July 22, 2025 20:30
@baileympearson baileympearson self-assigned this Jul 22, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 22, 2025
@baileympearson baileympearson merged commit 484adb9 into main Jul 22, 2025
26 of 28 checks passed
@baileympearson baileympearson deleted the NODE-6944 branch July 22, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@durran @baileympearson