Skip to content

refactor(NODE-7061): remove BulkWriteOperation, InsertManyOperation and BulkWriteShimOperation #4602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jul 29, 2025

Description

What is changing?

This PR removes three operation classes: BulkWriteOperation, InsertManyOperation and BulkWriteShimOperation. All of these operation classes provided a layer of indirection that

  1. was unnecessary
  2. resulted in at least one extra server selection when executing a bulk operation
Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title Node 7061 refactor(NODE-7061): remove BulkWriteOperation, InsertManyOperation and BulkWriteShimOperation Jul 29, 2025
@baileympearson baileympearson marked this pull request as ready for review July 30, 2025 02:55
@baileympearson baileympearson requested a review from a team as a code owner July 30, 2025 02:55
@durran durran self-assigned this Jul 30, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 30, 2025
@baileympearson baileympearson requested a review from durran July 30, 2025 14:15
@durran durran merged commit 5d79902 into main Jul 30, 2025
26 of 29 checks passed
@durran durran deleted the NODE-7061 branch July 30, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants