Skip to content

feat(NODE-7020): remove ping on connect #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 5, 2025
Merged

feat(NODE-7020): remove ping on connect #4607

merged 11 commits into from
Aug 5, 2025

Conversation

durran
Copy link
Member

@durran durran commented Aug 4, 2025

Description

Removes the ping command on client connect.

What is changing?

Switches from executing a ping to a connection checkout and checkin

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-7020

Release Highlight

Clients no longer send a ping on connect

When authentication is enabled, the MongoClient will no longer send a ping command when connecting since it is unnecessary. Instead it will check a connection out of the pool to force the initial handshake, and check it back in.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran changed the title Node 7020 feat(NODE-7020): remove ping on connect Aug 4, 2025
@durran durran marked this pull request as ready for review August 5, 2025 13:22
@durran durran requested a review from a team as a code owner August 5, 2025 13:22
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I can't resolve my threads 🐛

@baileympearson baileympearson self-assigned this Aug 5, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 5, 2025
@baileympearson baileympearson merged commit 3d296b7 into main Aug 5, 2025
27 of 31 checks passed
@baileympearson baileympearson deleted the NODE-7020 branch August 5, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants