refactor(NODE-7089): make AggregateOperation subclass ModernizedOperation #4608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
I broke this PR out of #4609 because it got kinda large.
This PR refactors AggregateOperation to subclass ModernizedOperation. Along the way, I encountered issues with
omitReadPreference
- an option which is used by the server class to remove a read preference from a command. To make this work with the existing design, thebuildOptions
method would need to start taking a reference to the connection to determine the maxWireVersion when attaching this option.I didn't like this approach and this option is only used for the AggregateOperation when there is a write stage and we are using wire version <9, so I refactored to remove this option.
After removing
omitReadPreference
, it became clear we no longer neededtrySecondaryWrite
, which is also only used for Aggregation operations but is present on all operation classes, only used to determine if we should setomitReadPreference
to true, and is assigned the same value has AggregateOperation.hasWriteStage.After that I had a circular dependency because execute_operation now imports a reference to AggregateOperation. I broke the circular dependency by removing ExplainableCursor from
explain.ts
.Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript