refactor(NODE-7084): refactor CUD ops to use ModernizedOperation #4610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-7084-cud-ops
branch
5 times, most recently
from
ef2dee8 to
ab880fd
Compare
baileympearson
force-pushed
the
NODE-7084-cud-ops
branch
from
a9c76d0 to
bb9e610
Compare
baileympearson
force-pushed
the
NODE-7084-cud-ops
branch
from
bb9e610 to
b42d7e7
Compare
durran
added
the
Primary Review
durran
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
The remaining CUD operations now subclass ModernizedOperation.
After implementing this PR, I noticed tests hanging in CI. I modified the leak checker to print which test in particular failed in order to debug the resource leak, and I left the improvements to the leak checker in this PR. The root cause of the leaks was errors thrown during command construction - a connection was never returned to the pool in this scenario.
Additionally, this PR uncovered a bug in the return type inference from executeOperation. Some operation subclasses override the return type of its superclass (ex: DeleteOneOperation returns a DeleteResult, but DeleteOperation returns Document). Before the changes to executeOperation in this PR, there are TS errors in collection.ts because TS infers that the return type of executeOperation is the superclass's return type, not the subclass's.
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript