feat(NODE-7100): make MONGODB_ERROR_CODES public #4615
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
changed the title
durran
added
tracked-in-jira
|
Hi @Khongchai, thanks for the contribution. We have a ticket tracking this and will discuss in our triage next week. |
baileympearson
added
the
Primary Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made MONGODB_ERROR_CODES public
What is the motivation for this change?
We have a use case where accessing the error code definition is useful for error checking. Checking
e.code === MONGODB_ERROR_CODES.Somethingseems pretty useful. The object is already frozen so we can't just accidentally modify this.This is a small type change so I haven't run any tests / compilation yet. But would be happy to do so if still required! Thanks, mongodb team