Skip to content

fix(NODE-7107): Use of password hash with insufficient computational effort #4619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(NODE-7107): Use of password hash with insufficient computational effort #4619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions src/cmap/auth/scram.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,19 +229,16 @@ function passwordDigest(username: string, password: string) {
throw new MongoInvalidArgumentError('Password cannot be empty');
}

let md5: crypto.Hash;
// Use PBKDF2 with SHA-256, 100,000 iterations, and a salt derived from username
const salt = Buffer.from(username + ':mongo', 'utf8');
const iterations = 100000;
const keylen = 32; // 256 bits
try {
md5 = crypto.createHash('md5');
const derivedKey = crypto.pbkdf2Sync(password, salt, iterations, keylen, 'sha256');
return derivedKey.toString('hex');
} catch (err) {
if (crypto.getFips()) {
// This error is (slightly) more helpful than what comes from OpenSSL directly, e.g.
// 'Error: error:060800C8:digital envelope routines:EVP_DigestInit_ex:disabled for FIPS'
throw new Error('Auth mechanism SCRAM-SHA-1 is not supported in FIPS mode');
}
throw err;
throw new MongoRuntimeError('Error hashing password with PBKDF2: ' + err.message);
}
md5.update(`${username}:mongo:${password}`, 'utf8');
return md5.digest('hex');
}

// XOR two buffers
Expand Down