Skip to content

Conversation

tadjik1
Copy link
Member

@tadjik1 tadjik1 commented Sep 22, 2025

Description

Summary of Changes

This PR migrates the integration tests for the Decimal128 class. The changes include:

  • Converting the test files from .js to .ts.
  • Replacing callbacks with async/await.
  • Using this.configuration to instantiate the client.
  • Importing directly from src to avoid using the legacy wrapper.
Notes for Reviewers

To simplify the review process, this PR is split into two commits:

  • The first commit covers the .js to .ts conversion.
  • The second commit contains the remaining refactoring changes.

What is the motivation for this change?

This work is part of a larger, ongoing initiative to convert all tests to use async/await, with the ultimate goal of removing the legacy driver wrapper.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 marked this pull request as ready for review September 22, 2025 10:23
@tadjik1 tadjik1 requested a review from a team as a code owner September 22, 2025 10:23
@baileympearson baileympearson self-assigned this Sep 22, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 22, 2025
@baileympearson
Copy link
Contributor

CI failures are unrelated.

@baileympearson baileympearson merged commit d2e856e into main Sep 22, 2025
24 of 31 checks passed
@baileympearson baileympearson deleted the NODE-7165 branch September 22, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants