Skip to content

Conversation

tadjik1
Copy link
Member

@tadjik1 tadjik1 commented Sep 23, 2025

Description

Summary of Changes

This PR migrates the integration tests for connection-monitoring-and-pooling. The changes include:

  • Replacing callbacks with async/await for one test.
  • Import directly from the src folder.
Notes for Reviewers

To simplify the review process, this PR is split into several commits:

  • The first commit converts callbacks to async/await.
  • Other commits contains the remaining refactoring changes (imports).

What is the motivation for this change?

This work is part of a larger, ongoing initiative to convert all tests to use async/await, with the ultimate goal of removing the legacy driver wrapper.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 marked this pull request as ready for review September 23, 2025 13:57
@tadjik1 tadjik1 requested a review from a team as a code owner September 23, 2025 13:57
@baileympearson baileympearson self-assigned this Sep 23, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 23, 2025
@baileympearson baileympearson merged commit 77f4343 into main Sep 24, 2025
28 of 31 checks passed
@baileympearson baileympearson deleted the NODE-7182 branch September 24, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants