Skip to content

Conversation

tadjik1
Copy link
Member

@tadjik1 tadjik1 commented Sep 25, 2025

Description

Summary of Changes

This PR migrates the integration tests for read-write-concern. The changes include:

  • Refactor callbacks into async/await
  • Import directly from the src folder, convert .js file test into .ts
Notes for Reviewers

To simplify the review process, this PR is split into 2 commits:

  • change .js into .ts
  • refactor test file

What is the motivation for this change?

This work is part of a larger, ongoing initiative to convert all tests to use async/await, with the ultimate goal of removing the legacy driver wrapper.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 marked this pull request as ready for review September 26, 2025 08:01
@tadjik1 tadjik1 requested a review from a team as a code owner September 26, 2025 08:01
@durran durran self-assigned this Sep 26, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 26, 2025
@durran durran merged commit 34a7dbd into main Sep 29, 2025
23 of 27 checks passed
@durran durran deleted the NODE-7184 branch September 29, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants