Skip to content

feat(NODE-6334)!: rename PoolRequstedRetry to PoolRequestedRetry #4696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

feat(NODE-6334)!: rename PoolRequstedRetry to PoolRequestedRetry #4696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cmap/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class PoolClearedError extends MongoNetworkError {
super(errorMessage, pool.serverError ? { cause: pool.serverError } : undefined);
this.address = pool.address;

this.addErrorLabel(MongoErrorLabel.PoolRequstedRetry);
this.addErrorLabel(MongoErrorLabel.PoolRequestedRetry);
}

override get name(): string {
Expand Down
4 changes: 2 additions & 2 deletions src/error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export const MongoErrorLabel = Object.freeze({
ResumableChangeStreamError: 'ResumableChangeStreamError',
HandshakeError: 'HandshakeError',
ResetPool: 'ResetPool',
PoolRequstedRetry: 'PoolRequstedRetry',
PoolRequestedRetry: 'PoolRequestedRetry',
InterruptInUseConnections: 'InterruptInUseConnections',
NoWritesPerformed: 'NoWritesPerformed'
} as const);
Expand Down Expand Up @@ -1444,7 +1444,7 @@ export function needsRetryableWriteLabel(
export function isRetryableWriteError(error: MongoError): boolean {
return (
error.hasErrorLabel(MongoErrorLabel.RetryableWriteError) ||
error.hasErrorLabel(MongoErrorLabel.PoolRequstedRetry)
error.hasErrorLabel(MongoErrorLabel.PoolRequestedRetry)
);
}

Expand Down
4 changes: 2 additions & 2 deletions test/integration/retryable-writes/non-server-retryable_writes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('Non Server Retryable Writes', function () {
});

it(
'returns the original error with a PoolRequstedRetry label after encountering a WriteConcernError',
'returns the original error with a PoolRequestedRetry label after encountering a WriteConcernError',
{ requires: { topology: 'replicaset' } },
async () => {
const serverCommandStub = sinon.stub(Server.prototype, 'command');
Expand All @@ -46,7 +46,7 @@ describe('Non Server Retryable Writes', function () {
const insertResult = await collection.insertOne({ _id: 1 }).catch(error => error);
sinon.restore();

expect(insertResult.errorLabels).to.be.deep.equal(['PoolRequstedRetry']);
expect(insertResult.errorLabels).to.be.deep.equal(['PoolRequestedRetry']);
}
);
});