feat(NODE-6473)!: remove MONGODB-CR auth #4717
Conversation
durran
changed the title
tadjik1
added
the
Primary Review
| [ | ||
| AuthMechanism.MONGODB_CR, | ||
| () => { | ||
| throw new MongoInvalidArgumentError( | ||
| 'MONGODB-CR is no longer a supported auth mechanism in MongoDB 4.0+' | ||
| ); | ||
| } | ||
| ], |
There was a problem hiding this comment.
Just to clarify the statement from the ticket and PR description about raising an error if user tries to use this method: since after this removal we won't raise it explicitly this is going to be raised as standard MongoParseError (as it showed in tests), is that correct?
There was a problem hiding this comment.
Thanks @durran, everything looks good to me, I only want to clarify if I understood correctly your approach for this statement from the ticket:
If the driver exposes the authentication mechanism in a public API, then:
Deprecate MONGODB-CR and raise an error indicating to the user that MONGODB-CR is no longer supported in MongoDB 4.0 and subsequently the current driver version.
We had already done that - so now we've just removed it from the public API (via AuthMechanism) and throw the common error for missing auth mech. |
Description
Fully removes MONGODB-CR.
Summary of Changes
Notes for Reviewers
What is the motivation for this change?
Release Highlight
MONGODB-CR AuthMechanism removed.
Attempting to use will still raise an error.
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript