feat(NODE-4184)!: don't throw on aggregate with write concern and explain #4718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
commented
Oct 7, 2025
durran
changed the title
tadjik1
added
the
Primary Review
tadjik1
reviewed
Oct 8, 2025
tadjik1
reviewed
Oct 8, 2025
tadjik1
added
Team Review
baileympearson
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Driver no longer throws on an aggregation when write concern and explain are provided. Server will now error.
Summary of Changes
Removes the check in the driver and updates tests.
What is the motivation for this change?
NODE-4184
Release Highlight
Aggregate with Write Concern + Explain No Longer Throws Client Side
This will now throw a
MongoServerErrorDouble check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript