test(NODE-5206): fix flaky sdam prose test#4752
Merged
baileympearson merged 1 commit intomainfrom Oct 30, 2025
Merged
Conversation
durran
commented
Oct 23, 2025
test/integration/server-discovery-and-monitoring/server_discovery_and_monitoring.prose.test.ts
Show resolved
Hide resolved
durran
commented
Oct 23, 2025
test/integration/server-discovery-and-monitoring/server_discovery_and_monitoring.prose.test.ts
Show resolved
Hide resolved
baileympearson
added
the
Primary Review
baileympearson
suggested changes
Oct 23, 2025
Contributor
baileympearson
left a comment
baileympearson
left a comment
There was a problem hiding this comment.
Do we know why this test started failing much more frequently in the last few months and why it seems to most frequently (maybe only?) fail on latest servers with server API enabled?
Contributor
Author
I have no idea, but locally I could only get it to flake with the stable API enabled. Not limited to latest server as I'm on 8.0 locally, but I could not get the test to fail without the stable API enabled. And it was only one excessive failing hearbeat in the way no matter how much I tinkered with the heartbeat frequency. |
baileympearson
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the flaky SDAM prose test for connection pooling.
Summary of Changes
Updates the test to filter out rogue server heartbeat failed events.
What is the motivation for this change?
NODE-5206
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript