fix(NODE-7469): overload retry when retryReads/Writes=false#4888
Merged
fix(NODE-7469): overload retry when retryReads/Writes=false#4888
Conversation
63c5cd2 to
e516536
Compare
Contributor
Author
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds/updates client backpressure unified spec tests to verify that overload retries respect retryReads=false / retryWrites=false, and adjusts the overload retry gating logic in the driver accordingly.
Changes:
- Update backpressure spec test suites (loop + max-attempts) to ignore
killCursorsmonitoring noise and add coverage forretryReads/retryWrites=falsescenarios (including read vs write aggregate). - Regenerate corresponding JSON spec files from YAML updates.
- Modify overload retry eligibility logic in
executeOperationWithRetriesto consider retry settings forSystemOverloadedErrorcases.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/spec/client-backpressure/backpressure-retry-max-attempts.yml | Adds killCursors ignore and extends max-attempts coverage to include aggregate write case. |
| test/spec/client-backpressure/backpressure-retry-max-attempts.json | Regenerated JSON for the updated max-attempts YAML spec. |
| test/spec/client-backpressure/backpressure-retry-loop.yml | Adds clients with retryReads=false / retryWrites=false and many “does not retry” cases for overload errors. |
| test/spec/client-backpressure/backpressure-retry-loop.json | Regenerated JSON for the updated retry-loop YAML spec. |
| test/integration/client-backpressure/client-backpressure.spec.test.ts | Skips additional dropIndexes test case due to existing dropIndexes error-squashing behavior. |
| src/operations/execute_operation.ts | Changes overload retry gating to respect retry settings (but currently introduces a functional regression; see comment). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PavelSafronov
requested changes
Mar 11, 2026
PavelSafronov
approved these changes
Mar 11, 2026
dariakp
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
https://jira.mongodb.org/browse/NODE-7469
Check that false retry settings are respected for overload errors
Notes for Reviewers
Spec sync and crossed fingers.
What is the motivation for this change?
retryability should still be disabled even when overload errors are returned
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript