Skip to content

Conversation

blva
Copy link
Collaborator

@blva blva commented Sep 4, 2024

Proposed changes

Jira ticket: CLOUDP-271224

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Further comments

@blva blva changed the title Add spectral rules and validation CLOUDP-271224: Add spectral rules and validation for soa migration Sep 4, 2024
@blva blva marked this pull request as ready for review September 4, 2024 11:12
@blva blva requested a review from a team as a code owner September 4, 2024 11:12
@@ -0,0 +1,32 @@
# A Self-Documenting Makefile: http://marmelab.com/blog/2016/02/29/auto-documented-makefile.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this file if we are running spectral via the GH action?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep for local development

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all the changes

@blva blva merged commit 4062955 into main Sep 4, 2024
8 checks passed
@blva blva deleted the spectral branch September 4, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants