CLOUDP-277321: reverted changelog changes #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
FYI: This PR also fixes the changelog end-to-end (e2e) tests, which started failing because the newly generated changelog did not include the invite endpoints. As a result, the e2e tests were failing due to a mismatch between the generated changelog and the expected one.
e2e tests should not depend on our current changelog right? we can address in the TODO ticket?
andreaangiolillo
commented
Oct 7, 2024
tools/cli/test/data/changelog/same-api-version/base/openapi-2023-01-01.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-277321
This PR manually updates the prod changelog to remove the entries related to the invite endpoints.
FYI: This PR also fixes the changelog end-to-end (e2e) tests, which started failing because the newly generated changelog did not include the invite endpoints. As a result, the e2e tests were failing due to a mismatch between the generated changelog and the expected one.