CLOUDP-284014: Check soa migration in external path #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
commented
Nov 12, 2024
| basePaths.Set(path, removeExternalRefs(externalPathData)) | ||
| } else { | ||
| if err := o.handlePathConflict(originalPathData, path); err != nil { | ||
| if err := o.handlePathConflict(externalPathData, path); err != nil { |
There was a problem hiding this comment.
main change: we were getting the originalPathData (baseData, which is mms, but we expect annotations to be in SOA)
There was a problem hiding this comment.
What does it mean "expect annotations to be in SOA"? Do you mean the file path of the spec was MMS but we need the service spec instead?
There was a problem hiding this comment.
expect annotations to be in Standalone service, correct. We were adding the annotation to MMS, but it should live in the standalone service once the copy endpoint is created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-284014
Checklist
Changes to Spectral
Further comments