Skip to content

CLOUDP-283505: Allow empty removals #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2024
Merged

CLOUDP-283505: Allow empty removals #275

merged 3 commits into from
Nov 12, 2024

Conversation

blva
Copy link
Collaborator

@blva blva commented Nov 12, 2024 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-283505

Description

Changelog generation failed with:

2024/11/04 16:14:51 Marked 414 changes hidden from the changelog.
Error: the pattern for response-property-enum-value-removed message was changed. Expecting exactly 2 values between apostrophes: removed the '' enum value from the 'results/items/oneOf[subschema #4: Host Metric Alerts]/currentValue/units' response property

However the info is valid, since there was an empty enum in the OpenAPI specification, see https://github.com/10gen/mms/pull/113043.

This PR updates the Regex so that we allow empty values.

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

  • I have read the README file for Spectral Updates

Further comments

@blva blva marked this pull request as ready for review November 12, 2024 12:01
@blva blva requested a review from a team as a code owner November 12, 2024 12:01
andreaangiolillo
andreaangiolillo approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva merged commit 7f0b7f2 into main Nov 12, 2024
10 checks passed
@blva blva deleted the CLOUDP-283505 branch November 12, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blva @andreaangiolillo