Skip to content

chore: Update hiddenEntries counter #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blva merged 2 commits into from
Nov 13, 2024
Merged

chore: Update hiddenEntries counter #280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f77f3ca
Update hiddenEntries counter
blva Nov 12, 2024
c865044
Fix lint
blva Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tools/cli/internal/changelog/outputfilter/hide.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,10 @@ func hideByExemptions(entries []*OasDiffEntry, exemptions []breakingchanges.Exem
hiddenEntries := 0
for _, entry := range entries {
if entry.HideFromChangelog {
hiddenEntries++
continue
}

for _, exemption := range exemptionsMarkedHidden {
// If the path is not empty and the path is not in the exemption, skip
if entry.Path != "" && !strings.Contains(exemption.BreakingChangeDescription, entry.Path) {
Expand All @@ -79,8 +81,10 @@ func hideByExemptions(entries []*OasDiffEntry, exemptions []breakingchanges.Exem
continue
}

// Mark entry as hidden and break the exemption loop.
entry.HideFromChangelog = true
hiddenEntries++
break
}
}

Expand Down
Loading