Skip to content

Conversation

lovisaberggren
Copy link
Collaborator

@lovisaberggren lovisaberggren commented Nov 22, 2024

Proposed changes

  • Moving package.json to root for sharing between tools
  • Added Prettier and ESLint
  • Added GH workflow step for Prettier and ESLint

Jira ticket: CLOUDP-286235

Running locally:

# Reformat with Prettier
npm run format

# Run Prettier check (no reformat)
npm run format-check

# Run ESLint check (JS files)
npm run lint-js

Further comments

We can consider running the existing spectral linting with the package.json instead of a makefile (planned approach for new ipa validator)

@lovisaberggren lovisaberggren marked this pull request as ready for review November 22, 2024 17:58
@lovisaberggren lovisaberggren requested a review from a team as a code owner November 22, 2024 17:58
"dependencies": {
"openapi-to-postmanv2": "4.24.0"
},
"devDependencies": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be done as a follow up but let's make sure dependabot tracks this file

with:
node-version: '20.x'
- name: Install npm dependencies
uses: nick-fields/retry@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, also updated the same on the req spec validations workflow 👍

@lovisaberggren lovisaberggren merged commit d76fac4 into main Nov 25, 2024
11 checks passed
@lovisaberggren lovisaberggren deleted the CLOUDP-286235 branch November 25, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants