Skip to content

Conversation

wtrocki
Copy link
Member

@wtrocki wtrocki commented Dec 11, 2024

Proposed changes

Jira ticket: CLOUDP-278958

Cleanup parameters. We are recommending and documenting users to use the environment.
All parameters we have are unused and might lead to confusion.

Testing

  • Generated collection locally and tested it.

@wtrocki wtrocki requested a review from a team as a code owner December 11, 2024 10:00
@wtrocki wtrocki force-pushed the CLOUDP-278958-cleanup-params branch 3 times, most recently from ea7bc72 to 964a9e2 Compare December 11, 2024 10:22
@wtrocki wtrocki force-pushed the CLOUDP-278958-cleanup-params branch from 964a9e2 to 2057198 Compare December 11, 2024 12:08
Copy link
Collaborator

@matt-condon matt-condon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wtrocki wtrocki merged commit 7a1fb77 into main Dec 12, 2024
11 checks passed
@wtrocki wtrocki deleted the CLOUDP-278958-cleanup-params branch December 12, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants