Skip to content

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Dec 12, 2024

Proposed changes

Jira ticket: CLOUDP-277156

This PR updates the foas breaking-changes exemptions parse command to always validate the exemption file.

Before

./bin/foascli breaking-changes exemptions parse --exemption-file ~/Downloads/exemptions.yaml --ignore-expiration

2024/12/12 15:17:54 Generating exemptions from file in /Users/andrea.angiolillo/Downloads/exemptions.yaml
2024/12/12 15:17:54 Found 1251 valid exemptions
2024/12/12 15:17:54 Exemptions file generated in exemptions.txt

After

foascli breaking-changes exemptions parse --exemption-file ~/Downloads/exemptions.yaml --ignore-expiration                            

2024/12/12 16:18:39 Generating exemptions from file in /Users/andrea.angiolillo/Downloads/exemptions.yaml
Error: could not get valid exemptions list: validation error: parsing time "20240810" as "2006-01-02": cannot parse "0810" as "-". Exemption: {API None None removed the schema 'ClusterDescription20240710' [api-schema-removed] 20240810 Exemption for cloud-dev only, generated as a result of un-hiding the new version in cloud-dev true}

@andreaangiolillo andreaangiolillo marked this pull request as ready for review December 12, 2024 16:19
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner December 12, 2024 16:19
@andreaangiolillo andreaangiolillo changed the title CLOUDP-277156: [API Platform] Lint exemptions CLOUDP-277156: [API Platform] Validate exemptions Dec 12, 2024
@andreaangiolillo andreaangiolillo merged commit c22eebe into main Dec 12, 2024
10 checks passed
@andreaangiolillo andreaangiolillo deleted the CLOUDP-286014 branch December 12, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants