CLOUDP-290332: Run IPA validation and Jest tests as workflow #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| with: | ||
| sparse-checkout: | | ||
| .github | ||
| tools |
There was a problem hiding this comment.
Q: Wouldn't it be better if we check /tools/spectral/ipa than tools?
There was a problem hiding this comment.
I was thinking to use /tools in case we add new jest tests in other tools as well in the future, but no strong opinion, I can change to /tools/spectral/ipa for now
There was a problem hiding this comment.
I thought we only plan writing jest tests within /tools/spectral/ipa directory for the scope of IPA validation, but feel free to revert if any plan to add new tests outside of this directory
There was a problem hiding this comment.
Yeah there's no plans now, so I'll keep the change 👍
yelizhenden-mdb
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
/tools(js-test)/tools(IPA validation action). Should not fail as the rules are currently warningJira ticket: CLOUDP-290332
Testing: