Skip to content

fix: fed creds fix #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix: fed creds fix #329

merged 3 commits into from
Dec 19, 2024

Conversation

blva
Copy link
Collaborator

@blva blva commented Dec 19, 2024 •
edited
Loading

Proposed changes

  • Updates to use a variable instead of secret

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

  • I have read the README file for Spectral Updates

Further comments

@blva blva requested a review from a team as a code owner December 19, 2024 15:14
@blva blva changed the title Fed creds fix fix: fed creds fix Dec 19, 2024
andreaangiolillo
andreaangiolillo approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andreaangiolillo
andreaangiolillo reviewed Dec 19, 2024
View reviewed changes
@blva blva merged commit 01ef9ab into main Dec 19, 2024
11 checks passed
@blva blva deleted the fed-creds-fix branch December 19, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

+1 more reviewer

@abhirawat abhirawat abhirawat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blva @andreaangiolillo @abhirawat