Skip to content

fix: fed creds fix #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix: fed creds fix #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edd8b36
fix: add permission to parent workflow
blva Dec 19, 2024
4c97b67
Merge remote-tracking branch 'origin/main' into fed-creds-fix
blva Dec 19, 2024
f6ce736
update
blva Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/generate-openapi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@ on:
description: 'Version of FOASCLI to use.'
required: true
type: string
aws_s3_role_to_assume:
description: 'AWS S3 Role to Assume.'
required: true
type: string
secrets: # all secrets are passed explicitly in this workflow
api_bot_pat:
required: true
aws_s3_role_to_assume:
required: true

permissions:
contents: write
Expand Down Expand Up @@ -62,7 +64,7 @@ jobs:
- name: aws configure
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ secrets.aws_s3_role_to_assume }}
role-to-assume: ${{ inputs.aws_s3_role_to_assume }}
aws-region: ${{inputs.aws_default_region}}
- name: Retrieve Specs
env:
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/release-changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,15 @@ on:
description: 'Version of FOASCLI to use.'
required: true
type: string
aws_s3_role_to_assume:
description: 'AWS S3 Role to Assume.'
required: true
type: string
secrets: # all secrets are passed explicitly in this workflow
api_bot_pat:
required: true
aws_s3_role_to_assume:
required: true



permissions:
contents: write
issues: write
Expand Down Expand Up @@ -91,7 +94,7 @@ jobs:
- name: aws configure
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ secrets.aws_s3_role_to_assume }}
role-to-assume: ${{ inputs.aws_s3_role_to_assume }}
aws-region: ${{inputs.aws_default_region}}
- name: Generate Changelog
env:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release-spec-runner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ jobs:
uses: ./.github/workflows/release-spec.yml
secrets:
api_bot_pat: ${{ secrets.API_BOT_PAT }}
aws_s3_role_to_assume: ${{ secrets.aws_s3_role_to_assume }}
jira_api_token: ${{ secrets.JIRA_API_TOKEN }}
with:
aws_default_region: ${{ vars.AWS_DEFAULT_REGION}}
aws_s3_bucket: ${{ vars.S3_BUCKET_DEV}}
aws_s3_role_to_assume: ${{ vars.AWS_S3_ROLE_TO_ASSUME }}
env: dev
branch: dev
spectral_version: ${{ vars.SPECTRAL_VERSION }}
Expand All @@ -68,10 +68,10 @@ jobs:
uses: ./.github/workflows/release-spec.yml
secrets:
api_bot_pat: ${{ secrets.API_BOT_PAT }}
aws_s3_role_to_assume: ${{ secrets.aws_s3_role_to_assume }}
jira_api_token: ${{ secrets.JIRA_API_TOKEN }}
with:
aws_default_region: ${{ vars.AWS_DEFAULT_REGION}}
aws_s3_role_to_assume: ${{ vars.AWS_S3_ROLE_TO_ASSUME }}
aws_s3_bucket: ${{ vars.S3_BUCKET_QA}}
env: qa
branch: qa
Expand All @@ -85,10 +85,10 @@ jobs:
uses: ./.github/workflows/release-spec.yml
secrets:
api_bot_pat: ${{ secrets.API_BOT_PAT }}
aws_s3_role_to_assume: ${{ secrets.aws_s3_role_to_assume }}
jira_api_token: ${{ secrets.JIRA_API_TOKEN }}
with:
aws_default_region: ${{ vars.AWS_DEFAULT_REGION}}
aws_s3_role_to_assume: ${{ vars.AWS_S3_ROLE_TO_ASSUME }}
aws_s3_bucket: ${{ vars.S3_BUCKET_STAGING}}
env: stage
branch: staging
Expand All @@ -102,12 +102,12 @@ jobs:
uses: ./.github/workflows/release-spec.yml
secrets:
api_bot_pat: ${{ secrets.API_BOT_PAT }}
aws_s3_role_to_assume: ${{ secrets.aws_s3_role_to_assume }}
postman_api_key: ${{ secrets.POSTMAN_API_KEY }}
workspace_id: ${{ secrets.WORKSPACE_ID }}
jira_api_token: ${{ secrets.JIRA_API_TOKEN }}
with:
aws_default_region: ${{ vars.AWS_DEFAULT_REGION}}
aws_s3_role_to_assume: ${{ vars.AWS_S3_ROLE_TO_ASSUME }}
aws_s3_bucket: ${{ vars.S3_BUCKET_PROD}}
env: prod
branch: main
Expand All @@ -122,10 +122,10 @@ jobs:
uses: ./.github/workflows/release-spec-v1.yml
secrets:
api_bot_pat: ${{ secrets.API_BOT_PAT }}
aws_s3_role_to_assume: ${{ secrets.aws_s3_role_to_assume }}
mms_deployed_sha_url: ${{ secrets.MMS_DEPLOYED_SHA_URL_PROD }}
with:
aws_default_region: ${{ vars.AWS_DEFAULT_REGION}}
aws_s3_role_to_assume: ${{ vars.AWS_S3_ROLE_TO_ASSUME }}
aws_s3_bucket: ${{ vars.S3_BUCKET_PROD}}
env: prod
branch: main
8 changes: 5 additions & 3 deletions .github/workflows/release-spec-v1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@ on:
description: 'Branch to release the OpenAPI Spec to.'
required: true
type: string
aws_s3_role_to_assume:
description: 'AWS S3 Role to Assume.'
required: true
type: string
secrets: # all secrets are passed explicitly in this workflow
api_bot_pat:
required: true
aws_s3_role_to_assume:
required: true
mms_deployed_sha_url:
required: true

Expand All @@ -39,7 +41,7 @@ jobs:
- name: aws configure
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ secrets.aws_s3_role_to_assume }}
role-to-assume: ${{ inputs.aws_s3_role_to_assume }}
aws-region: ${{inputs.aws_default_region}}
- name: Download v1 Spec
env:
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/release-spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ on:
description: 'Base URL of Atlas.'
required: false
type: string
aws_s3_role_to_assume:
description: 'AWS S3 Role to Assume.'
required: true
type: string
secrets: # all secrets are passed explicitly in this workflow
api_bot_pat:
required: true
Expand All @@ -39,8 +43,6 @@ on:
required: false
jira_api_token:
required: true
aws_s3_role_to_assume:
required: true

permissions:
contents: write
Expand All @@ -53,10 +55,10 @@ jobs:
uses: ./.github/workflows/generate-openapi.yml
secrets:
api_bot_pat: ${{ secrets.api_bot_pat }}
aws_s3_role_to_assume: ${{ secrets.aws_s3_role_to_assume }}
with:
aws_default_region: ${{ inputs.aws_default_region}}
aws_s3_bucket: ${{ inputs.aws_s3_bucket}}
aws_s3_role_to_assume: ${{ inputs.aws_s3_role_to_assume }}
env: ${{ inputs.env }}
foascli_version: ${{ inputs.foascli_version }}

Expand Down Expand Up @@ -168,9 +170,9 @@ jobs:
uses: ./.github/workflows/release-changelog.yml
secrets:
api_bot_pat: ${{ secrets.api_bot_pat }}
aws_s3_role_to_assume: ${{ secrets.aws_s3_role_to_assume }}
with:
aws_default_region: ${{ inputs.aws_default_region}}
aws_s3_role_to_assume: ${{ inputs.aws_s3_role_to_assume }}
aws_s3_bucket: ${{ inputs.aws_s3_bucket}}
env: ${{ inputs.env }}
branch: ${{ inputs.branch }}
Expand Down
Loading