Skip to content

Conversation

lovisaberggren
Copy link
Collaborator

Proposed changes

Updated the spec with a change to the exception format, now the exceptions are formatted as follows:

"x-xgen-IPA-exception": {
  "xgen-IPA-104-resource-has-GET": "Legacy API, not used by infrastructure-as-code tooling",
  "xgen-IPA-105-resource-has-LIST": "Legacy API, not used by infrastructure-as-code tooling"
},

Previously:

"x-xgen-IPA-exception": {
  "xgen-IPA-104-resource-has-GET": {
    "reason": "Legacy API, not used by infrastructure-as-code tooling"
  },
  "xgen-IPA-105-resource-has-LIST": {
    "reason": "Legacy API, not used by infrastructure-as-code tooling"
  }
},
  • Updated the exception format validation to validate the new format
  • Updated exceptions in tests

Jira ticket: CLOUDP-288860

@lovisaberggren lovisaberggren marked this pull request as ready for review December 19, 2024 16:07
@lovisaberggren lovisaberggren requested a review from a team as a code owner December 19, 2024 16:07
Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice change! Thank you

@lovisaberggren lovisaberggren merged commit 8162fb7 into main Dec 19, 2024
13 checks passed
@lovisaberggren lovisaberggren deleted the CLOUDP-288860 branch December 19, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants