Skip to content

CLOUDP-293820: Update optional validations workflow to use cached npm #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovisaberggren merged 1 commit into from
Jan 9, 2025
Merged

CLOUDP-293820: Update optional validations workflow to use cached npm #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/optional-spec-validations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '20.x'
cache: 'npm'
- name: Install npm dependencies
run: npm install
- name: Download openapi-foas
uses: actions/download-artifact@v4
with:
Expand Down
8 changes: 7 additions & 1 deletion tools/postman/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,13 @@ The OpenAPI path for Postman generation and configured feature flags can also be

### Running locally

Once env vars are configured, the setup scripts can be run locally using the Make following commands:
Once env vars are configured, install the required dependencies:

```
npm install
```

Then, the setup scripts can be run locally using the Make following commands:
- `make fetch_openapi`
- `make convert_to_collection` - covert OpenAPI to Postman collection
- `make transform_collection` - transform Postman collection to fix common issues
Expand Down
3 changes: 0 additions & 3 deletions tools/postman/scripts/convert-to-collection.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ TMP_FOLDER=${TMP_FOLDER:-"../tmp"}
echo "Removing regex"
jq 'del(.. | select(type == "object") | .pattern?)' "$OPENAPI_FOLDER"/"$OPENAPI_FILE_NAME" > "$TMP_FOLDER"/tmp.json

echo "Installing openapi-to-postmanv2"
npm install

echo "Converting $OPENAPI_FOLDER/$OPENAPI_FILE_NAME from OpenAPI to PostmanV2"
npx openapi2postmanv2 -s "$TMP_FOLDER"/tmp.json -o "$TMP_FOLDER"/"$COLLECTION_FILE_NAME" -O folderStrategy=Tags

Expand Down
Loading