Skip to content

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jan 10, 2025

Proposed changes

Jira ticket: CLOUDP-261180

This PR adds a new filter to remove the unused schemas in the components section of the openapi spec.

@andreaangiolillo andreaangiolillo changed the title feat: added filter feat: Add filter to remove unused views Jan 13, 2025
@andreaangiolillo andreaangiolillo requested a review from Copilot March 5, 2025 17:05
@wtrocki
Copy link
Member

wtrocki commented Mar 13, 2025

@andreaangiolillo Is this still in your plans? That will significantly reduce openapi size. We could then remove several filters in SDK-go repository that try to archieve the same.

@andreaangiolillo andreaangiolillo changed the title feat: Add filter to remove unused views CLOUDP-261180: Add filter to remove unused views Mar 25, 2025
@@ -1,15 +1,4 @@
{
"info": {
Copy link
Collaborator Author

@andreaangiolillo andreaangiolillo Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to update the specifications used for the e2e split command tests. The issue was that, due to the filters applied, the generated specs were missing unused schemas. This caused the test to fail because the generated specs were not identical to the expected ones.

@andreaangiolillo andreaangiolillo marked this pull request as ready for review March 25, 2025 17:07
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner March 25, 2025 17:07
@fmenezes
Copy link
Collaborator

[q] how about the main spec with all versions?

@andreaangiolillo
Copy link
Collaborator Author

[q] how about the main spec with all versions?

As part of the release process, we generate the v2.json specification containing all API versions. Then, we use the foascli filter command to clean up the spec by removing extensions and, after this PR, unused views as well. The foascli filter command relies on the filter list updated in this PR. Once we release the updated version of foascli, it will automatically start using the new filter configuration. @fmenezes

@andreaangiolillo andreaangiolillo requested a review from gssbzn March 26, 2025 10:39
@andreaangiolillo andreaangiolillo merged commit cf99d06 into main Mar 26, 2025
10 checks passed
@andreaangiolillo andreaangiolillo deleted the CLOUDP-261180 branch March 26, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants