-
Notifications
You must be signed in to change notification settings - Fork 15
CLOUDP-292068: Remove x-xgen-IPA-exception from version split OASes #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ad8a0f7
CLOUDP-292068: Remove x-xgen-IPA-exception from version split OASes
lovisaberggren 5863688
CLOUDP-292068: Lint
lovisaberggren a3bddf3
CLOUDP-292068: Gen docs
lovisaberggren df83b40
CLOUDP-292068: Extract functions
lovisaberggren 7149e88
CLOUDP-292068: Lint
lovisaberggren fc93775
CLOUDP-292068: Comment fix
lovisaberggren a22f7d5
CLOUDP-292068: Add case for requestBody
lovisaberggren a345b32
CLOUDP-292068: Group consts
lovisaberggren 23e9da2
CLOUDP-292068: Test cases
lovisaberggren be8999b
CLOUDP-292068: Merge conflict
lovisaberggren cc0697f
CLOUDP-292068: Revert one line
lovisaberggren 17fb0c8
CLOUDP-292068: Parallel
lovisaberggren 99f7709
CLOUDP-292068: More functions
lovisaberggren 7646810
CLOUDP-292068: Merge conflict
lovisaberggren 2461711
CLOUDP-292068: Lint fix
lovisaberggren File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐻 with me this is a bit messy but need to look at the code in an editor to help you a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup it's a bit messy, happy to get feedback on this one 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to break the code into separate functions, with each function handling a specific component type? It might make the code easier to follow and maintain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yelizhenden-mdb 💯 yes that was one approach but I think filtering in general needs some love
I haven't really have the time to go deeper here since I found other stuff in the repo that needed fixing like some improved linting but you can split this in functions and leverage the fact that go encourage argument modification, is quite common in go to name an argument
outto flag it will be modified by the functionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split some parts to more functions, let me know if it's a bit better.
Not sure what you mean here, unless you mean naming the parameter to out