Skip to content

Conversation

yelizhenden-mdb
Copy link
Collaborator

@yelizhenden-mdb yelizhenden-mdb commented Jan 13, 2025

Proposed changes

Implements a Collector class which collects all the exceptions, violations and adoptions of IPA rules as an object of the component itself and the name of the related IPA rule.

It outputs all of the results to a JSON file

Jira ticket: CLOUDP-290417

Testing

When you run spectral lint command with the rulesets in ipa-spectral.yaml file, it will output a combined.log file which will collect all the exceptions, violations and adoptions.

Example file ipa-collector-results-combined.log, after the spectral linting on openapi/v2.json file
You can navigate to the lists of exceptions, violations and adoptions

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

  • I have read the README file for Spectral Updates

@yelizhenden-mdb yelizhenden-mdb marked this pull request as ready for review January 14, 2025 08:50
@yelizhenden-mdb yelizhenden-mdb requested a review from a team as a code owner January 14, 2025 08:50
Copy link
Collaborator

@lovisaberggren lovisaberggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, two nits, otherwise LGTM!

@yelizhenden-mdb yelizhenden-mdb merged commit 5cc211f into main Jan 14, 2025
13 checks passed
@yelizhenden-mdb yelizhenden-mdb deleted the CLOUDP-290417 branch January 14, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants