CLOUDP-294708: Add IPA validation to optional spec validations workflow #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovisaberggren
commented
Jan 16, 2025
| cp -rf "openapi-foas.json" "./tools/postman/openapi/atlas-api.json" | ||
| pushd tools/postman | ||
| make convert_to_collection | ||
| npx -- @stoplight/spectral-cli@"${SPECTRAL_VERSION}" lint ./tmp/collection.json --ruleset=./validation/spectral.yaml |
There was a problem hiding this comment.
I wasn't sure why we run a pinned version for Postman here, passed as a variable (or where this variable is coming from). For IPA validations it will use the version from the package.json (same as the validation run on PRs/locally). We can update the Postman validation to use the same approach as IPA validation unless there is a reason for this approach here
blva
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds IPA validation to run on
optional-spec-validationsworkflow. Creates an issue if the validation fails, similarly to the Postman validation.Jira ticket: CLOUDP-294708