-
Notifications
You must be signed in to change notification settings - Fork 14
CLOUDP-298521: Decouple IPA Metrics Collection Job from FOAS Release GH Workflow #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8eb4be9
CLOUDP-298521: Decouple IPA Metrics Collection Job from FOAS Release …
yelizhenden-mdb 8dc3505
fix gh lint
yelizhenden-mdb e0f30db
address the comments
yelizhenden-mdb 7b96f33
address the comments
yelizhenden-mdb d62d16d
address the comments
yelizhenden-mdb 902f3f3
address the comments
yelizhenden-mdb ef5446f
address the comments
yelizhenden-mdb a14c9ca
address the comments
yelizhenden-mdb 6ac0539
address the comments
yelizhenden-mdb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,8 @@ permissions: | |
| env: | ||
| NODE_VERSION: '20.x' | ||
| WORKING_DIR: ./tools/spectral/ipa/metrics/scripts | ||
| RELEASE_ENV: 'dev' | ||
| OAS_ENV: 'dev' | ||
| OAS_BRANCH: 'main' | ||
|
|
||
| jobs: | ||
| # Generates and uploads the IPA validation metrics to S3 | ||
|
|
@@ -30,10 +31,27 @@ jobs: | |
| - name: Install npm dependencies | ||
| run: npm install | ||
|
|
||
| - name: Checkout repository | ||
| uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 | ||
| with: | ||
| ref: $OAS_BRANCH | ||
| token: ${{secrets.API_BOT_PAT}} | ||
|
|
||
| - name: Upload current Specs and Changelog files | ||
| uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 | ||
| with: | ||
| name: base-$OAS_ENV | ||
| retention-days: 1 | ||
| path: | | ||
| openapi/v2/openapi*.json | ||
| changelog/changelog.json | ||
| changelog/internal/changelog-all.json | ||
| changelog/internal/metadata.json | ||
|
||
|
|
||
| - name: Download openapi-foas | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: openapi-foas-$RELEASE_ENV | ||
| name: openapi-foas-$OAS_ENV | ||
| github-token: ${{ secrets.API_BOT_PAT }} | ||
|
|
||
| - name: Run Metric Collection Job | ||
|
|
@@ -54,7 +72,7 @@ jobs: | |
| if: ${{ failure() }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| uses: ./.github/workflows/failure-handler.yml | ||
| with: | ||
| env: $RELEASE_ENV | ||
| release_name: "OpenAPI Spec" | ||
| env: $OAS_ENV | ||
| release_name: "IPA Metrics" | ||
| secrets: | ||
| jira_api_token: ${{ secrets.JIRA_API_TOKEN }} | ||
27 changes: 0 additions & 27 deletions
27
tools/spectral/ipa/metrics/scripts/getShouldRunMetricsRelease.js
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.