Skip to content

CLOUDP-297221: Add preview support to split command #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 7, 2025
Merged

CLOUDP-297221: Add preview support to split command #410

merged 4 commits into from
Feb 7, 2025
+83 −20

Conversation

@blva
Copy link
Collaborator

@blva blva commented Feb 6, 2025 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-297221

  • Allows the split command to handle preview, using exact match only, which means only the preview endpoints will get added to the preview spec
  • Moves stability level checks into apiversion library, also making it use case insensitive

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

  • I have read the README file for Spectral Updates

Further comments

@blva blva requested a review from a team as a code owner February 6, 2025 14:54
andreaangiolillo
andreaangiolillo approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva marked this pull request as draft February 6, 2025 15:16
wtrocki
wtrocki approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Congratulations on milestone!
Would we have preview this release to see this in action?

@blva blva marked this pull request as ready for review February 6, 2025 17:59
@blva
Copy link
Collaborator Author

blva commented Feb 6, 2025 •
edited
Loading

Would we have preview this release to see this in action?

i don't think so, max in dev branch for api registry but not sure if we have everything in place for it to get commited

@blva blva merged commit 2b53038 into main Feb 7, 2025
11 checks passed
@blva blva deleted the CLOUDP-297221 branch February 7, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtrocki wtrocki wtrocki approved these changes

@andreaangiolillo andreaangiolillo Awaiting requested review from andreaangiolillo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blva @wtrocki @andreaangiolillo