Skip to content

CLOUDP-296432: Update IPA release workflow #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 10, 2025
Merged

CLOUDP-296432: Update IPA release workflow #414

merged 7 commits into from
Feb 10, 2025

Conversation

@yelizhenden-mdb
Copy link
Collaborator

@yelizhenden-mdb yelizhenden-mdb commented Feb 10, 2025 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-296432

  1. Instead of checking out dev branch, uploading the oas to the artifacts, and downloading it when we are on main branch, we are downloading latest dev openapi spec using curl (following the suggestion on previous PR)
    (Tested and verified that the spec is downloaded to working directory without a problem)
  2. Replaced staging credentials with prod ones

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

  • I have read the README file for Spectral Updates

@yelizhenden-mdb yelizhenden-mdb marked this pull request as ready for review February 10, 2025 10:10
@yelizhenden-mdb yelizhenden-mdb requested a review from a team as a code owner February 10, 2025 10:10
@wtrocki wtrocki changed the title CLOUDP-296432: Update IPA release workflow to dump to production s3 CLOUDP-296432: Update IPA release workflow Feb 10, 2025
wtrocki
wtrocki approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@wtrocki
Copy link
Member

wtrocki commented Feb 10, 2025

I really like the idea of downloading OAS file instead of tooling! great job!

@yelizhenden-mdb yelizhenden-mdb merged commit c854575 into main Feb 10, 2025
11 checks passed
@yelizhenden-mdb yelizhenden-mdb deleted the CLOUDP-296432 branch February 10, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtrocki wtrocki wtrocki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yelizhenden-mdb @wtrocki