Skip to content

Conversation

@blva
Copy link
Collaborator

@blva blva commented Feb 17, 2025

Proposed changes

Jira ticket: CLOUDP-294902

I think I added both supports so I'm adding more testing and some error handling

Happy cases

➜  cli git:(CLOUDP-294902) ✗ ./bin/foascli versions -s test/data/base_spec_with_private_preview.json
[
  "2023-01-01",
  "2023-02-01",
  "2023-10-01",
  "2023-11-15",
  "2024-05-30",
  "2024-08-05",
  "2024-10-23",
  "2024-11-13",
  "2025-05-30",
  "2043-01-01",
  "private-preview-new-feature"
]

➜  cli git:(CLOUDP-294902) ✗ ./bin/foascli versions -s test/data/base_spec_with_public_preview.json 
[
  "2023-01-01",
  "2023-02-01",
  "2023-10-01",
  "2023-11-15",
  "2024-05-30",
  "2024-08-05",
  "2024-10-23",
  "2024-11-13",
  "2025-05-30",
  "2043-01-01",
  "preview"
]

Errrors / linting

➜  cli git:(CLOUDP-294902) ✗ ./bin/foascli versions -s test/data/base_spec_with_public_preview.json
failed to parse preview version name: invalid value for 'public' field, only 'true' or 'false' are allowed
Error: invalid value for 'public' field, only 'true' or 'false' are allowed

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

  • I have read the README file for Spectral Updates

Further comments

@blva blva marked this pull request as ready for review February 17, 2025 15:20
@blva blva requested a review from a team as a code owner February 17, 2025 15:20
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva merged commit 5bf5528 into main Feb 17, 2025
9 of 11 checks passed
@blva blva deleted the CLOUDP-294902 branch February 17, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants