Skip to content

CLOUDP-301911: Add preview changelog test #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 24, 2025
Merged

CLOUDP-301911: Add preview changelog test #442

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
562477f
CLOUDP-301911: Add preview changelog test
blva Feb 21, 2025
ae3c11b
update
blva Feb 21, 2025
d532d32
Update
blva Feb 21, 2025
a5567c9
Fix tests
blva Feb 21, 2025
854f21d
Address comments
blva Feb 24, 2025
9731371
Address comments
blva Feb 24, 2025
109bc88
Update tools/cli/test/data/changelog/new-api-preview-version/revision…
blva Feb 24, 2025
48159d5
Update tools/cli/test/data/changelog/new-api-preview-version/base/met…
blva Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions tools/cli/internal/changelog/changelog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"os"
"time"

"github.com/mongodb/openapi/tools/cli/internal/apiversion"
"github.com/mongodb/openapi/tools/cli/internal/openapi"
"github.com/tufin/oasdiff/checker"
"github.com/tufin/oasdiff/diff"
Expand Down Expand Up @@ -173,6 +174,11 @@ func NewEntries(basePath, revisionPath, exceptionFilePath string) ([]*Entry, err
}

for _, version := range changelog.RevisionMetadata.Versions {
// Skip preview versions
if apiversion.IsPreviewSabilityLevel(version) {
continue
}

changelog.RevisionMetadata.ActiveVersion = version
changelog.BaseMetadata.ActiveVersion = version
changelog.Revision, err = newOpeAPISpecFromPathAndVersion(changelog.RevisionMetadata.Path, version)
Expand Down Expand Up @@ -213,6 +219,10 @@ func NewEntriesBetweenRevisionVersions(revisionPath, exceptionFilePath string) (
entries := []*Entry{}
for idx, fromVersion := range revisionMetadata.Versions {
for _, toVersion := range revisionMetadata.Versions[idx+1:] {
// skip preview versions
if apiversion.IsPreviewSabilityLevel(fromVersion) || apiversion.IsPreviewSabilityLevel(toVersion) {
continue
}
entry, err := newEntriesBetweenVersion(revisionMetadata, fromVersion, toVersion, exceptionFilePath)
if err != nil {
return nil, err
Expand Down Expand Up @@ -420,6 +430,9 @@ func latestVersionActiveOnDate(date string, versions []string) (string, error) {

activeVersions := []time.Time{}
for _, version := range versions {
if apiversion.IsPreviewSabilityLevel(version) {
continue
}
versionTime, err := newDateFromString(version)
if err != nil {
return "", err
Expand Down
Loading
Loading