Skip to content

Conversation

@andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Feb 21, 2025

Proposed changes

oasdif v1.10.26 updated the logic to consider adding schema to oneOf as breaking: oasdiff/oasdiff#611

This PR updates our changelog files to reflect this new behaviour and update the dependencies to the latest/
Jira ticket: CLOUDP-302126

@andreaangiolillo andreaangiolillo marked this pull request as ready for review February 21, 2025 13:09
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner February 21, 2025 13:09
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we have a follow-up item to know if we also consider it a breaking change or if we should ignore it?

@andreaangiolillo
Copy link
Collaborator Author

ticket: https://jira.mongodb.org/browse/CLOUDP-302138. I will follow up on slack

@andreaangiolillo andreaangiolillo merged commit 20458ba into main Feb 21, 2025
9 of 11 checks passed
@andreaangiolillo andreaangiolillo deleted the CLOUDP-302126 branch February 21, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants