-
Notifications
You must be signed in to change notification settings - Fork 14
CLOUDP-288870: Add a ⭐️ to the most recent version of the Admin API Postman collection #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| echo "Updating name with version $current_api_revision" | ||
| jq --arg api_version "$current_api_revision" \ | ||
| '.collection.info.name = ("MongoDB Atlas Administration API " + $api_version)' \ | ||
| '.collection.info.name = ("⭐MongoDB Atlas Administration API " + $api_version)' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| '.collection.info.name = ("⭐MongoDB Atlas Administration API " + $api_version)' \ | |
| '.collection.info.name = ("[Latest] MongoDB Atlas Administration API " + $api_version)' \ |
I am wondering why we went for the ⭐ . Isn't clearer to use Latest instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The discussion started with using ⭐. I'm fine with changing it to [Latest]. Has there been a product decision on this? cc @matt-condon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yelizhenden-mdb Feel free to go ahead and use latest as star might not be universally recognizable across the globe as "first"/"latest".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rationale behind the ⭐ is there's a precedent for it and it probably stands out a bit more
I'm fine with [latest] but probably not [first]
Do we generally have a way that we denote the latest API version across docs for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disscussed offline. ⭐ is the visual clue we want :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yelizhenden-mdb We need to make change to js transformer as well, but happy to do it myself as I have introduced duplication
|
Creating follow up PR. |
Proposed changes
Jira ticket: CLOUDP-288870
The script is changed as:
Testing
I've run the commands against an empty workspace, and it created the collection with the star in the name.
Checklist
Changes to Spectral
Further comments