CLOUDP-304430: allow multiple formats #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
changed the title
andreaangiolillo
approved these changes
Mar 6, 2025
| const ( | ||
| JSON = "json" | ||
| YAML = "yaml" | ||
| ALL = "all" |
There was a problem hiding this comment.
[No need to address the comment]. Something to consider in the future is tohave the --format flag as a list so that we can provide multiple formats. The drawback of having ALL are:
- it is not clear what ALL traslate to by looking at the command but we force users to run --help
- if we add support for another format (not likely), ALL will start generating other format too 🤔
I think is fine to have all since we are the user of this cli and it is not likely we will support other formats
There was a problem hiding this comment.
ack, if we add more formats we can defintely revisit! or keep supporitng the all to generate all formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-304430
Checklist
Changes to Spectral
Further comments