CLOUDP-271991: IPA-104: Validate for Get methods the response is 200 #462
Conversation
| return; | ||
| } | ||
|
|
||
| if (input['responses']) { |
There was a problem hiding this comment.
Something to consider here is that this test will cover IPA 105 List as well, since it's also a HTTP GET method, which may skew the metrics, and will cause duplicate validation if we are planning to implement the same check for IPA 105.
Also, this covers custom methods too, though IIRC we don't define that custom method GET should return 200. Maybe we should introduce a guideline for this on custom methods, or not do the validation if we think there is a reason for custom gets to return a 202 for example (though IMO it should be a custom post in that case)
There was a problem hiding this comment.
I modified the code as "If it is a custom method or collection resource (not a child with current glossary), the rule will be bypassed". Let me know what you think
| return; | ||
| } | ||
|
|
||
| if (input['responses']) { |
2 participants
Proposed changes
Jira ticket: CLOUDP-271991
Implements a Spectral rule to validate if Get method (single resource) has 200 OK status code and no other 2xx responses
If it is a custom method or collection resource, the rule will be bypassed.
Checklist
Changes to Spectral