fix: request body for preview is empty #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
reviewed
Feb 28, 2025
| "github.com/mongodb/openapi/tools/cli/internal/apiversion" | ||
| ) | ||
|
|
||
| // Filter: VersioningFilter is a filter that modifies the OpenAPI spec by removing operations and responses |
There was a problem hiding this comment.
// Filter: notation is used so that we can auto gen all the filters
There was a problem hiding this comment.
ah I was getting a warning in my IDE that this is not golang standard. I will revert the changes
There was a problem hiding this comment.
I reverted my changes. thanks!
blva
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Ticket: CLOUDP-303647
Bug
While migrating the API to preview in this PR https://github.com/10gen/mms/pull/122517, I noticed that the request body for the endpoint was not being populated. After reproducing the issue locally, I found the root cause: we use
time.Now()with the preview API, and when comparing the content type for preview usingtime.GreaterThan, the comparison always returnedtrue. This happened becausetime.GreaterThanwas factoring in minutes and seconds, even though both versions were set to preview.Fix
I updated the logic to use the same date as we have in Atlas so that we don't set HH:MM:SS.
I regenerated the preview spec locally and confirmed that the request body was correctly populated.