-
Notifications
You must be signed in to change notification settings - Fork 14
CLOUDP-303615: IPA - Update check if resource is singleton #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrocki
approved these changes
Mar 3, 2025
|
Converting to draft for now, will do some testing on exceptions |
| const RULE_NAME = 'xgen-IPA-104-get-method-returns-single-resource'; | ||
| const ERROR_MESSAGE_STANDARD_RESOURCE = | ||
| 'Get methods should return data for a single resource. This method returns an array or a paginated response.'; | ||
| const ERROR_MESSAGE_SINGLETON_RESOURCE = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
yelizhenden-mdb
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. High-value foundational work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
After discussions we have decided to slightly modify the check for if a resource is a "standard" resource or a singleton resource. For most resources, they will still be treated the same, but some resources will not be considered singleton anymore.
/resource/{id}/something/verb)Tests
resourceEvaluationfor checking for singleton resource, collection path or single pathFollow up
Jira ticket: CLOUDP-303615