-
Couldn't load subscription status.
- Fork 14
CLOUDP-303615: IPA - Update check if resource is singleton #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Converting to draft for now, will do some testing on exceptions |
| const RULE_NAME = 'xgen-IPA-104-get-method-returns-single-resource'; | ||
| const ERROR_MESSAGE_STANDARD_RESOURCE = | ||
| 'Get methods should return data for a single resource. This method returns an array or a paginated response.'; | ||
| const ERROR_MESSAGE_SINGLETON_RESOURCE = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. High-value foundational work!
Proposed changes
After discussions we have decided to slightly modify the check for if a resource is a "standard" resource or a singleton resource. For most resources, they will still be treated the same, but some resources will not be considered singleton anymore.
/resource/{id}/something/verb)Tests
resourceEvaluationfor checking for singleton resource, collection path or single pathFollow up
Jira ticket: CLOUDP-303615