-
Notifications
You must be signed in to change notification settings - Fork 14
CLOUDP-271997- IPA 108 Delete 404 status code is returned #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/spectral/ipa/rulesets/functions/deleteMethod404Response.js
Outdated
Show resolved
Hide resolved
tools/spectral/ipa/rulesets/functions/deleteMethod404Response.js
Outdated
Show resolved
Hide resolved
723063b to
f9c7030
Compare
… to delete a non-existing IPA
c6567f2 to
b265e4a
Compare
b265e4a to
e50ef70
Compare
|
Ready for another look. |
yelizhenden-mdb
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after description change
Co-authored-by: Lovisa Berggren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
This PR implements OpenAPI specification validation for IPA-108 guidelines related to DELETE operations. The implementation adds linting rules that verify DELETE methods follow REST API best practices.
Components Implemented
Rule: xgen-IPA-108-delete-include-404-response
Ensures DELETE operations include 404 responses for not found resources
Implemented in deleteMethod404Response.js