Skip to content

CLOUDP-271994: IPA-106: Validate Create methods accepts no query params (ignore envelope and pretty query params) #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

CLOUDP-271994: IPA-106: Validate Create methods accepts no query params (ignore envelope and pretty query params) #491

merged 1 commit into from
Mar 7, 2025

Conversation

@yelizhenden-mdb
Copy link
Collaborator

@yelizhenden-mdb yelizhenden-mdb commented Mar 6, 2025 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-271994

Ignore envelope and pretty query params because they are about response object formatting, and they are widely used in the MMS OpenAPI spec

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

  • I have read the README file for Spectral Updates

Further comments

@yelizhenden-mdb
CLOUDP-271994: IPA-106: Validate Create methods accepts no query para…
a8dff8c 
…ms (ignore envelope and pretty query params)
@yelizhenden-mdb yelizhenden-mdb marked this pull request as ready for review March 6, 2025 17:43
@yelizhenden-mdb yelizhenden-mdb requested a review from a team as a code owner March 6, 2025 17:43
wtrocki
wtrocki approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as workaround for the current problem.
In long run we need global exceptions in spectral or openapi.
Exceptions should be defined and provided as input to validator downstream.

@yelizhenden-mdb yelizhenden-mdb merged commit a988e11 into main Mar 7, 2025
13 checks passed
@yelizhenden-mdb yelizhenden-mdb deleted the CLOUDP-271994/fix branch March 7, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtrocki wtrocki wtrocki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yelizhenden-mdb @wtrocki